thereadme/snaphash
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

check single element type to be html image element #1

Closed
mamal72 wants to merge 1 commits from gh-pages into gh-pages
pull from: gh-pages
merge into: :gh-pages
Conversation 1 Commits 1 Files Changed 1
+4 -4
mamal72 commented 2015-09-25 17:24:06 +00:00 (Migrated from github.com)
Copy Link
Copy Source
No description provided.
mdibaiee commented 2015-09-25 17:45:25 +00:00 (Migrated from github.com)
Copy Link
Copy Source

I and @mamal72 talked about this, in conclusion I think we might not want this

  • If we are going to check against Image elements, we will have to check every array element (e.g. array.every)
  • There might be cases where the user uses a more general selector which might include other elements
  • If the user really is giving us invalid elements, he is doing it wrong.
I and @mamal72 talked about this, in conclusion I think we might not want this - If we are going to check against Image elements, we will have to check every array element (e.g. `array.every`) - There might be cases where the user uses a more general selector which might include other elements - If the user really is giving us invalid elements, he is doing it wrong.

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
thereadme
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thereadme/snaphash#1