thereadme/node-telegram-api
1
0
Fork 0
Code Issues 9 Pull Requests Projects Releases Wiki Activity

chore: don't copy build/types folder to the project's root; get rid of redundant dependency #46

Closed
laurynas-karvelis wants to merge 1 commits from chore/dont-duplicate-types-folder into master
pull from: chore/dont-duplicate-types-folder
merge into: thereadme:master
Conversation 1 Commits 1 Files Changed 2 +1 -14
laurynas-karvelis commented 2018-12-24 09:37:47 +00:00 (Migrated from github.com)
Copy Link

For no reason types/ folder used to be copied to the project's root after invoking grunt command to build src dir.

For no reason `types/` folder used to be copied to the project's root after invoking `grunt` command to build `src` dir.
mdibaiee commented 2018-12-24 11:40:42 +00:00 (Migrated from github.com)
Copy Link

Hi,

The copy is not redundant, it's there to allow easier access to types by requiring telegram-api/types.

Please close the pull-request unless you want to discuss this further

Hi, The copy is not redundant, it's there to allow easier access to types by requiring `telegram-api/types`. Please close the pull-request unless you want to discuss this further

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
thereadme
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thereadme/node-telegram-api#46
Delete Branch "chore/dont-duplicate-types-folder"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?