thereadme/node-telegram-api
1
0
Fork 0
Code Issues 9 Pull Requests Projects Releases Wiki Activity

Don't add 'getUpdates' request to the queue #44

Merged
laurynas-karvelis merged 1 commits from master into master 2018-04-20 11:32:48 +00:00
Conversation 3 Commits 1 Files Changed 1 +5
laurynas-karvelis commented 2018-04-20 10:40:23 +00:00 (Migrated from github.com)
Copy Link

I've figured out why after addition of global message queue mechanism introduction all messages get sent out with 20s delay. This is caused by the 'getUpdates' times out exactly after 20s as per default module config. This patch invokes 'getUpdates' right away skipping that request from being added to the message queue hence fixing those message delivery delays.

I've figured out why after addition of global message queue mechanism introduction all messages get sent out with 20s delay. This is caused by the 'getUpdates' times out exactly after 20s as per default module config. This patch invokes 'getUpdates' right away skipping that request from being added to the message queue hence fixing those message delivery delays.
mdibaiee commented 2018-04-20 11:32:43 +00:00 (Migrated from github.com)
Copy Link

That's good to know, thanks!

That's good to know, thanks!
mdibaiee commented 2018-04-20 11:35:05 +00:00 (Migrated from github.com)
Copy Link

Published as node-telegram-api@4.1.0

nit: I noticed there was a linting error in code, please run grunt to make sure there are no errors and build is successful, thanks!

Published as `node-telegram-api@4.1.0` nit: I noticed there was a linting error in code, please run `grunt` to make sure there are no errors and build is successful, thanks!
laurynas-karvelis commented 2018-04-20 11:36:28 +00:00 (Migrated from github.com)
Copy Link

Hi, sorry, forgot that. Will do next time :), Thanks for the merge!

Hi, sorry, forgot that. Will do next time :), Thanks for the merge!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: thereadme/node-telegram-api#44
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?