Allow sending messages longer than 4096 chars #41

2018-02-27T12:04:31Z

laurynas-karvelis commented

2018-02-27 12:04:31 +00:00

(Migrated from github.com)

This will split message into 4096 char chunks and send one after another.

mdibaiee commented

2018-02-27 15:00:50 +00:00

(Migrated from github.com)

@laurynas-karvelis Hey! Thanks for this, I think we should move the handling of this case to Message.js and set a custom send method instead of the if statement in Base.js, what do you think?

@laurynas-karvelis Hey! Thanks for this, I think we should move the handling of this case to [`Message.js`](https://github.com/mdibaiee/node-telegram-api/blob/master/src/types/Message.js#L96) and set a custom `send` method instead of the `if` statement in `Base.js`, what do you think?

laurynas-karvelis commented

2018-02-27 16:20:52 +00:00

(Migrated from github.com)

This is what I've achieved so far, I suppose this makes sense.
Edit: bump :)

This is what I've achieved so far, I suppose this makes sense. Edit: bump :)

mdibaiee (Migrated from github.com) approved these changes 2018-03-02 08:05:28 +00:00

mdibaiee (Migrated from github.com) left a comment

Sorry for the delay, I had forgotten about this since the notification was already marked as read.

Looks good, thanks a lot!
By the way, I would like to make you a collaborator on the repository, do you mind if I add you to the npm package and GitHub repository as a collaborator? Pull-requests are going to be necessary still but I want you to have more control 😁 - If so, please send me your npm credentials as well

Sorry for the delay, I had forgotten about this since the notification was already marked as read. Looks good, thanks a lot! By the way, I would like to make you a collaborator on the repository, do you mind if I add you to the npm package and GitHub repository as a collaborator? Pull-requests are going to be necessary still but I want you to have more control :grin: - If so, please send me your npm credentials as well

mdibaiee commented

2018-03-02 08:13:22 +00:00

(Migrated from github.com)

Published telegram-api@3.0.0

Published `telegram-api@3.0.0`

laurynas-karvelis commented

2018-03-14 09:39:16 +00:00

(Migrated from github.com)

Hi @mdibaiee, sorry for such a long response :). I'd like to keep contributing once in a while by submitting PRs instead of being repo collaborator. I'm not sure how actively I'll keep on developing with this module, hence won't be able to stay always up-to-date with the codebase etc.
I might come back with additional PR sometime soon-ish regards persisting Markdown/HTML structure once a long message gets split up into multiple 4Kb chunks.

Hi @mdibaiee, sorry for such a long response :). I'd like to keep contributing once in a while by submitting PRs instead of being repo collaborator. I'm not sure how actively I'll keep on developing with this module, hence won't be able to stay always up-to-date with the codebase etc. I might come back with additional PR sometime soon-ish regards persisting Markdown/HTML structure once a long message gets split up into multiple 4Kb chunks.

👍 1

mdibaiee commented

2018-03-14 10:41:35 +00:00

(Migrated from github.com)

@laurynas-karvelis I understand, I would like to thank you for your contributions anyways. 😁👍

@laurynas-karvelis I understand, I would like to thank you for your contributions anyways. :grin::+1:

laurynas-karvelis commented

2018-03-14 12:08:10 +00:00

(Migrated from github.com)

Thank You for this great module :)

Sign in to join this conversation.

No reviewers