Fix edge case when message object is undefined #37

2018-02-01T15:05:43Z

laurynas-karvelis commented

2018-02-01 15:05:43 +00:00

(Migrated from github.com)

It appears when communicating with telegram bot rapidly, entire message object sometimes becomes undefined, hence forcing node.js to throw an underfined 'chat' property error.

This is a quick fix, although it fixes the symptom, I'm not entirely sure it fixes the cause of this error.
Looking forward to your feedback.

Thank you for this awesome lib, BTW! :)

It appears when communicating with telegram bot rapidly, entire message object sometimes becomes undefined, hence forcing node.js to throw an underfined 'chat' property error. This is a quick fix, although it fixes the symptom, I'm not entirely sure it fixes the cause of this error. Looking forward to your feedback. Thank you for this awesome lib, BTW! :)

mdibaiee commented

2018-02-01 15:49:45 +00:00

(Migrated from github.com)

@laurynas-karvelis Thanks for the pull-request! I see, that makes sense, not all updates have a message property, it is an optional property. Sometimes there are edited_message, etc. instead. (https://core.telegram.org/bots/api#getting-updates)

anyways, I think your solution works! will publish a new version 👍

@laurynas-karvelis Thanks for the pull-request! I see, that makes sense, not all updates have a `message` property, it is an optional property. Sometimes there are `edited_message`, etc. instead. (https://core.telegram.org/bots/api#getting-updates) anyways, I think your solution works! will publish a new version :+1:

mdibaiee commented

2018-02-01 15:51:30 +00:00

(Migrated from github.com)

Published telegram-api@0.9.1

Published `telegram-api@0.9.1`

laurynas-karvelis commented

2018-02-01 15:55:40 +00:00

(Migrated from github.com)

Wow, that was a quick merge and publish! Once again, thanks a lot!

👍 1 😆 1

Sign in to join this conversation.

No reviewers