feat: customizable message for required params #36

2017-09-12T09:14:10Z

amovah commented

(Migrated from github.com)

mdibaiee (Migrated from github.com) requested changes 2017-09-12 11:58:20 +00:00

mdibaiee (Migrated from github.com) left a comment

Thanks Ali

src/index.js

mdibaiee (Migrated from github.com) commented

I'm not in favor of optional arguments that come in the middle and not the end.
Let's move this to the last argument to avoid confusions.

I'm not in favor of optional arguments that come in the middle and not the end. Let's move this to the last argument to avoid confusions.

amovah commented

(Migrated from github.com)

I've changed the code, as you wish.

mdibaiee (Migrated from github.com) requested changes 2017-09-12 14:16:25 +00:00

src/index.js

mdibaiee (Migrated from github.com) commented

I think you can instead do this:

const msg = new Message().to(msg.chat.id).text(customMessage[param] || `Enter value for ${param}`)

I think you can instead do this: ```javascript const msg = new Message().to(msg.chat.id).text(customMessage[param] || `Enter value for ${param}`) ```

amovah (Migrated from github.com) reviewed 2017-09-12 15:58:24 +00:00

src/index.js

amovah (Migrated from github.com) commented

yea, it's good idea. it's done.

mdibaiee (Migrated from github.com) approved these changes 2017-09-12 16:04:06 +00:00

mdibaiee (Migrated from github.com) left a comment

Thanks

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: thereadme/node-telegram-api#36