thereadme/hapi-sequelize-crud
1
0
Fork 0
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add more integration tests #31

Merged
joeybaker merged 7 commits from code-coverage into master 2016-10-28 18:28:06 +00:00
Conversation 4 Commits 7 Files Changed 11 +213 -7
joeybaker commented 2016-10-28 18:25:00 +00:00 (Migrated from github.com)
Copy Link

As is now usual, and unsurprising, adding tests revealed problems. So, as is now usual, this includes fixes.

This is technically a minor release, because it enables /lists?order=columnname%20DESC which part of the code had working, but validation disabled.

As is now usual, and unsurprising, adding tests revealed problems. So, as is now usual, this includes fixes. This is technically a minor release, because it enables `/lists?order=columnname%20DESC` which part of the code had working, but validation disabled.
🎉 2
joeybaker commented 2016-10-28 18:25:35 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee This is fairly straightforward. I'll merge it soon unless you say differently.

@mdibaiee This is fairly straightforward. I'll merge it soon unless you say differently.
👍 1
codecov-io commented 2016-10-28 18:26:11 +00:00 (Migrated from github.com)
Copy Link

Current coverage is 62.21% (diff: 100%)

Merging #31 into master will increase coverage by 5.62%

@@             master        #31   diff @@
==========================================
  Files             9          9          
  Lines           440        442     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            249        275    +26   
+ Misses          191        167    -24   
  Partials          0          0

Powered by Codecov. Last update 3b962ce...cb6ea51

## [Current coverage](https://codecov.io/gh/mdibaiee/hapi-sequelize-crud/pull/31?src=pr) is 62.21% (diff: 100%) > Merging [#31](https://codecov.io/gh/mdibaiee/hapi-sequelize-crud/pull/31?src=pr) into [master](https://codecov.io/gh/mdibaiee/hapi-sequelize-crud/branch/master?src=pr) will increase coverage by **5.62%** ``` diff @@ master #31 diff @@ ========================================== Files 9 9 Lines 440 442 +2 Methods 0 0 Messages 0 0 Branches 0 0 ========================================== + Hits 249 275 +26 + Misses 191 167 -24 Partials 0 0 ``` > Powered by [Codecov](https://codecov.io?src=pr). Last update [3b962ce...cb6ea51](https://codecov.io/gh/mdibaiee/hapi-sequelize-crud/compare/3b962ce4d8e40225f4fd6610a5c190c5e8621b14...cb6ea518361700793d4bdd5f81650c5368c4669b?src=pr)
joeybaker commented 2016-10-28 18:28:55 +00:00 (Migrated from github.com)
Copy Link

Released as 2.8.0

Released as 2.8.0
mdibaiee commented 2016-10-28 18:29:12 +00:00 (Migrated from github.com)
Copy Link

@joeybaker Thank you Joey! 🙏

@joeybaker Thank you Joey! :pray:
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
help wanted

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: thereadme/hapi-sequelize-crud#31
No description provided.
Delete Branch "code-coverage"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?