Um, parseWhere returns a flat object containing key: values of the query, and we set that to where, what's wrong with that? I mean parseWhere doesn't return where: {}, does it?
Um, `parseWhere` returns a flat object containing `key: value`s of the query, and we set that to `where`, what's wrong with that? I mean `parseWhere` doesn't return `where: {}`, does it?
It depends on the query parameters it gets, so if you pass it a where=someJSON, yes, it returns an object with a key where, but if you just pass plain query parameters, like name=joey, it will return { name: 'joey' }. Am I right?
In this case, this patch breaks the name=joey style (I actually used this style in my own code, that's why I was surprised 😁).
It depends on the query parameters it gets, so if you pass it a `where=someJSON`, yes, it returns an object with a key `where`, but if you just pass plain query parameters, like `name=joey`, it will return `{ name: 'joey' }`. Am I right?
In this case, this patch breaks the `name=joey` style (I actually used this style in my own code, that's why I was surprised :grin:).
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Otherwise we get a sequelize options object that looks like
@mdibaiee quick bug fix
Um,
parseWherereturns a flat object containingkey: values of the query, and we set that towhere, what's wrong with that? I meanparseWheredoesn't returnwhere: {}, does it?It actually does return an object with a key of
where:/It depends on the query parameters it gets, so if you pass it a
where=someJSON, yes, it returns an object with a keywhere, but if you just pass plain query parameters, likename=joey, it will return{ name: 'joey' }. Am I right?In this case, this patch breaks the
name=joeystyle (I actually used this style in my own code, that's why I was surprised 😁).Ah! Understood. I misunderstood how this was supposed to work.
I'll add docs instead :)
Pull request closed