thereadme/hapi-sequelize-crud
1
0
Fork 0
Code Issues 4 Pull Requests 1 Projects Releases Wiki Activity

Add: permissions #11

Merged
joeybaker merged 1 commits from add-permissions into master 2016-07-22 17:28:36 +00:00
Conversation 10 Commits 1 Files Changed 2 +102 -34
joeybaker commented 2016-07-22 01:01:20 +00:00 (Migrated from github.com)
Copy Link

It's now possible to limit the models rest routes are created for. This
is done via a models option that can be simple to complex. The readme
has been updated to reflect this.

It's now possible to limit the models rest routes are created for. This is done via a `models` option that can be simple to complex. The readme has been updated to reflect this.
mdibaiee commented 2016-07-22 09:23:39 +00:00 (Migrated from github.com)
Copy Link

Hey Joey, this is great! Thanks 👍

I wanted to add you as a collaborator before, but I wanted to ask you if that's okay with you, is it? 😀

Hey Joey, this is great! Thanks :+1: I wanted to add you as a collaborator before, but I wanted to ask you if that's okay with you, is it? :grinning:
mdibaiee commented 2016-07-22 09:34:09 +00:00 (Migrated from github.com)
Copy Link

@joeybaker oh, please also lint your code (npm run lint and npm run lint -- --fix) to avoid multiple styles in code.

@joeybaker oh, please also lint your code (`npm run lint` and `npm run lint -- --fix`) to avoid multiple styles in code.
👍 1
joeybaker commented 2016-07-22 14:46:56 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee I'll do the fixes today. I'd be happy to be a collaborator – as I mentioned previously, we've started to use this a lot, and have small changes like this that we need :)

@mdibaiee I'll do the fixes today. I'd be happy to be a collaborator – as I mentioned previously, we've started to use this a lot, and have small changes like this that we need :)
👍 1
joeybaker commented 2016-07-22 16:55:44 +00:00 (Migrated from github.com)
Copy Link

Just noting: I've got the linter setup in my editor so things should all happen automatically. I ran it manually with --fix and nothing changed :)

Just noting: I've got the linter setup in my editor so things should all happen automatically. I ran it manually with `--fix` and nothing changed :)
joeybaker commented 2016-07-22 16:56:46 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee updated.

@mdibaiee updated.
mdibaiee commented 2016-07-22 16:58:49 +00:00 (Migrated from github.com)
Copy Link

@joeybaker: Does your editor use the .eslintrc inside project folder? Also do you have the latest eslint-config-pichak package installed? The version in package.json is 1.1.0.

@joeybaker: Does your editor use the `.eslintrc` inside project folder? Also do you have the latest `eslint-config-pichak` package installed? The version in `package.json` is `1.1.0`.
joeybaker commented 2016-07-22 17:13:34 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee my editor does, but I did not! Fixing…

@mdibaiee my editor does, but I did not! Fixing…
joeybaker commented 2016-07-22 17:14:28 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee fixed.

@mdibaiee fixed.
joeybaker commented 2016-07-22 17:56:26 +00:00 (Migrated from github.com)
Copy Link

@mdibaiee I've found a logic hole in this API. Working on a fix. (Sorry about this).

@mdibaiee I've found a logic hole in this API. Working on a fix. (Sorry about this).
joeybaker commented 2016-07-22 18:39:34 +00:00 (Migrated from github.com)
Copy Link

see #14

see #14
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
thereadme
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: thereadme/hapi-sequelize-crud#11
Delete Branch "add-permissions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?