Add integration tests #27

2016-10-26T20:28:35Z

joeybaker commented

2016-10-26 20:28:35 +00:00

(Migrated from github.com)

This starts us off with integration tests. I think these will be easier to reason about than the pure unit-test style I was attempting before.

addresses #27

It does include a few minor fixes these tests discovered, so this is a patch release.

This starts us off with integration tests. I think these will be easier to reason about than the pure unit-test style I was attempting before. addresses #27 It does include a few minor fixes these tests discovered, so this is a patch release.

joeybaker commented

2016-10-26 20:32:28 +00:00

(Migrated from github.com)

@mdibaiee I like this direction a lot more for tests. It's easier to grok even if it will give less find-grained errors. I created #28 to track progress on completion. We could turn on coveralls.io or somesuch and have AVA spit out test coverage.

@mdibaiee I like this direction a lot more for tests. It's easier to grok even if it will give less find-grained errors. I created #28 to track progress on completion. We _could_ turn on coveralls.io or somesuch and have [AVA spit out test coverage](https://github.com/avajs/ava#code-coverage).

mdibaiee commented

2016-10-26 20:34:33 +00:00

(Migrated from github.com)

@joeybaker I think I learned a thing or two from this pull-request. Thanks 😁 👍

@joeybaker I think I learned a thing or two from this pull-request. Thanks :grin: :+1:

😆 1

mdibaiee commented

2016-10-26 20:36:18 +00:00

(Migrated from github.com)

@joeybaker sure, I personally used codecov.io for a few other projects, but it's up to you to choose.

@joeybaker sure, I personally used [codecov.io](http://codecov.io/) for a few other projects, but it's up to you to choose.

joeybaker commented

2016-10-26 21:10:44 +00:00

(Migrated from github.com)

Released as 2.7.2

joeybaker commented

2016-10-26 21:12:25 +00:00

(Migrated from github.com)

@mdibaiee I'm not particular. I also don't have access to setup integrations. Would you mind enabling codecov.io?

mdibaiee commented

2016-10-26 21:56:20 +00:00

(Migrated from github.com)

@joeybaker sure, I just enabled it, here is what needs to be modified in the Travis CI config file after coverage reports:

after_success:
  - bash <(curl -s https://codecov.io/bash)

@joeybaker sure, I just enabled it, here is what needs to be modified in the Travis CI config file after coverage reports: ``` yaml after_success: - bash <(curl -s https://codecov.io/bash) ```

joeybaker commented

2016-10-26 21:57:20 +00:00

(Migrated from github.com)

Cool. I'll set it up in a bit.

Sign in to join this conversation.

No reviewers